| íëĒŠ | ë´ėŠ |
|---|---|
| Invoke | /checklist:pr-review |
| Aliases | /check:pr, /pr:checklist |
| Category | petmedi-development |
| Complexity | moderate |
| MCP Servers | serena |
/checklist/pr-review#
Context Framework Note: Activates during PR reviews.
Triggers#
- During Pull Request reviews
- When code review is requested
- Final verification before merge
Usage#
/checklist/pr-review [PR number or link]
Quick Review (5-minute review)#
Minimum items to check when a quick review is needed:
- Build success (CI)
- Tests passing
- Lint check passing
- No security issues
- Breaking Changes verified
Full Review Checklist#
1. PR Meta Information#
-
PR title follows convention
- Format:
type(scope): gitmoji description
- Format:
- Related issues linked
- Appropriate labels assigned
2. Change Scope#
- PR purpose is clear
- Focused on a single purpose (one PR = one feature/fix)
- Change scope is appropriate
- No unnecessary file changes
3. Code Quality#
Architecture
- Clean Architecture layer separation followed
- Dependency direction correct (Domain â Data â Presentation)
- No cross-feature module dependencies
Naming & Readability
- Meaningful variable/function names
- Project naming conventions followed
- Appropriate comments
Code Structure
- No duplicate code (DRY)
- Single Responsibility Principle followed
- Appropriate abstraction level
4. State Management (BLoC)#
- Event/State using Freezed
- Appropriate state separation
- Error handling implemented
- Loading state handled
- Resources released in dispose
5. Testing#
- Tests added for new features
- Existing tests passing
- Edge case tests included
6. Security#
- No hardcoded secrets
- No sensitive information in logs
- Input validation applied
7. Performance#
- No N+1 query issues
- Unnecessary re-renders prevented
- Image optimization applied
- Appropriate caching strategy
8. Internationalization#
- No hardcoded strings
- Translation keys added
9. Accessibility#
- Semantic labels applied
- Touch target size appropriate
10. Documentation#
- Public API documented
- Breaking Changes documented
Review Priority#
Must-Have (cannot Approve)#
- Build failure
- Test failure
- Security vulnerability
- Undocumented Breaking Change
- Architecture violation
Should-Have (can Approve after requesting improvements)#
- Insufficient performance optimization
- Insufficient test coverage
- Insufficient documentation
- Insufficient accessibility
Nice-to-Have (comment only)#
- Naming improvement suggestions
- Code style suggestions
- Additional optimization suggestions
Review Comment Templates#
Required Fix (Blocking)#
đ´ **[Required]** {description}
{code location}: {file}:{line}
**Problem**: {problem description}
**Suggestion**: {solution}
Improvement Request (Non-blocking)#
đĄ **[Improvement]** {description}
{code location}: {file}:{line}
**Current**: {current code}
**Suggestion**: {improved code}
Suggestion/Question#
đĸ **[Suggestion]** {description}
{code location}: {file}:{line}
**Question/Suggestion**: {content}
Praise#
⨠**Nice!** {description}
{code location}: {file}:{line}
{praise content}
Review Result Templates#
Approve â #
LGTM! đ
All checklist items verified.
- Build successful
- Tests passing
- No security issues
Request Changes đ#
Changes requested.
**Required fixes** (must resolve before merge):
1. {item 1}
2. {item 2}
**Recommended fixes** (optional):
1. {item 1}
Comment đŦ#
Overall looks good. A few questions/suggestions.
**Questions**:
1. {question 1}
**Suggestions**:
1. {suggestion 1}
CI/CD Verification#
gh pr checks [PR_NUMBER]
gh pr view [PR_NUMBER] --web
- Build successful
- Test successful
- Lint successful
- Coverage check
References#
- Detailed checklist:
.claude/checklists/pr-review.md - Feature complete checklist:
.claude/commands/checklist/feature-complete.md - Code review skill:
.claude/commands/code-review.md